Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dockerfile and devcontainer for pulumi/python #1834

Merged
merged 3 commits into from
Apr 25, 2024

Conversation

craddm
Copy link
Contributor

@craddm craddm commented Apr 22, 2024

✅ Checklist

  • You have given your pull request a meaningful title (e.g. Enable foobar integration rather than 515 foobar).
  • You are targeting the appropriate branch. If you're not certain which one this is, it should be develop.
  • Your branch is up-to-date with the target branch (it probably was when you started, but it may have changed since then).
  • You have marked this pull request as a draft and added '[WIP]' to the title if needed (if you're not yet ready to merge).

⤴️ Summary

Updates the Dockerfile and devcontainer file, reflecting updates and changes to the project that have been made since they were created.

  1. Updates Python version 3.12
  2. Updates Debian distro to bookworm
  3. Updates Pulumi to latest version
  4. Switches to install azure-cli from apt repositories instead of building locally, since it is now available there for arm64 architectures
  5. Installs hatch to allow dsh CLI to be built without having to install hatch manually
  6. Updates azure-cli to version 3.59.0

🌂 Related issues

🔬 Tests

Built devcontainer locally and used to build and run dsh CLI via hatch

@craddm craddm requested a review from a team as a code owner April 22, 2024 15:51
Copy link
Member

@jemrobinson jemrobinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

.devcontainer/devcontainer.json Outdated Show resolved Hide resolved
@jemrobinson jemrobinson merged commit ac92c32 into alan-turing-institute:develop Apr 25, 2024
10 checks passed
@craddm craddm deleted the update-devcontainer branch May 23, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants